couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb-couch pull request: Make sure we load all applications wit...
Date Tue, 20 Jan 2015 11:40:56 GMT
Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-couch/pull/32#issuecomment-70641516
  
    Yes, this fixes the issue. However, not sure about the fix correctness.
    
    `start_couch` is basically starts minimal CouchDB instance with the specified config files
(if any). Additionally, it may be instructed to start some more apps which implements some
features, like: couch_mrview, couch_replicator etc.
    
    This fix tries to break this and actually start minimal CouchDB instance + all the apps
with the stats definition. This isn't minimalistic instance anymore, but not yet complete
one.
    
    So the question is: do we ever need in such startup definition (minimal core+extra apps)?
May be we need to start CouchDB with all the apps all the time? Or even be more flexible:
provide `start_minimal_couch([IniFiles, [ExtraApps]])` and `start_full_couch([IniFiles])`
- what does it gives us? /cc @chewbranca 
    
    The more finest fix for the 2552 is to touch couch_mrview tests setup function to call
`start_couch` with `[couch_mrview]` extra app like couch_replicator does.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message