couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Adding React into Fauxton
Date Thu, 08 Jan 2015 13:06:20 GMT
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69176468
  
    great work, very promising! I left some comments from things that i stumbled upon at a
first glance. 
    
    The diff is hard to review (+183,439  −1,087) - can you separate everything into 4 commits
(or more) after addressing the small things i found?
    
    suggestion:
    
     - adding react libraries
     - setup react build
     - rewrite navbar
     - rewrite editor
    
    I think this makes reviewing a lot easier and I can give better feedback afterwards.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message