couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Keep track of sidebar status
Date Tue, 06 Jan 2015 06:43:21 GMT
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-68832058
  
    @benkeen this is a nice idea. The code needs some neatening up. Rather create an object
that hides away the fact that you using localStorage to keep state. The api could be something
like:
    
        SideBarState = {
          isMinimized: function () { .... },
          setState: function () {....}
        };
    
    Then instead of reading the stored state and setting it in main.js rather do that in Fauxton/base.js.
I think thats a better place to do that. Most likely in the module initialise method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message