Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B400310AC1 for ; Wed, 10 Dec 2014 16:35:36 +0000 (UTC) Received: (qmail 79097 invoked by uid 500); 10 Dec 2014 16:35:36 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 79033 invoked by uid 500); 10 Dec 2014 16:35:36 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 79018 invoked by uid 99); 10 Dec 2014 16:35:35 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Dec 2014 16:35:35 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 76485A23E84; Wed, 10 Dec 2014 16:35:35 +0000 (UTC) From: iilyak To: dev@couchdb.apache.org Reply-To: dev@couchdb.apache.org Message-ID: Subject: [GitHub] couchdb-couch pull request: 26566 maximize attachment sharing betw... Content-Type: text/plain Date: Wed, 10 Dec 2014 16:35:35 +0000 (UTC) GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/22 26566 maximize attachment sharing between revisions of a document This fixes multiple copies of the same attachment in case of two documents having the same attachment content. You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch 26566-maximize-attachment-sharing-between-revisions-of-a-document Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 ---- commit 30bf4c63bbb7bba604a24b5048fd901eef3413fc Author: ILYA Khlopotov Date: 2014-12-09T21:26:01Z Test for number of att copies after compaction Compactor copies same attachment multiple times. This happens in the case when two docs upload the same attachment. Hence we write a test before implementing a fix for the problem. BugzID: 26566 commit af397aa1c23e93c62ad4f115329579a802a2e505 Author: ILYA Khlopotov Date: 2014-12-09T22:56:45Z Pass dict around to store already processed atts BugxID: 26566 commit 4a60847aba4adeaaa5a44b2bc546921261952889 Author: ILYA Khlopotov Date: 2014-12-09T23:11:37Z Convert map to mapfoldl so we can use Dict passed BugzID: 26566 commit e992d71ae265ab75ad3724cea7106bb780400dec Author: ILYA Khlopotov Date: 2014-12-10T00:20:59Z Fix the issue by introducing maybe_copy_att_data BugzID: 26566 commit 36ff5b57085b5e93ce8aca09bace1bfd1ea690b5 Author: ILYA Khlopotov Date: 2014-12-10T00:44:18Z Extract read_doc_with_atts function BugzID: 26566 ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---