Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: kxepal <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-13-couchdb-couch-mrview@git.apache.org>
In-Reply-To: <git-pr-13-couchdb-couch-mrview@git.apache.org>
Subject: [GitHub] couchdb-couch-mrview pull request: 1145 local docs handler
Content-Type: text/plain
Message-Id: <20141230205427.992BDA0F8A4@tyr.zones.apache.org>
Date: Tue, 30 Dec 2014 20:54:27 +0000 (UTC)

Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/13#discussion_r22364337
  
    --- Diff: src/couch_mrview_http.erl ---
    @@ -48,6 +50,22 @@ handle_all_docs_req(#httpd{method='POST'}=Req, Db) ->
     handle_all_docs_req(Req, _Db) ->
         couch_httpd:send_method_not_allowed(Req, "GET,POST,HEAD").
     
    +handle_local_docs_req(#httpd{method='GET'}=Req, Db) ->
    +    all_docs_req(Req, Db, undefined, <<"_local">>);
    --- End diff --
    
    Should this handler be for db admins only? Since by simple list of all local documents the replication checkpoints becomes disclosed and any user may touch each without restrictions. Currently they are in safe just because it doesn't simply to guess their id. I think until proper _local docs validate_doc_update handler they shouldn't be disclosed to the world expect database admins who are directly interested in them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---