Return-Path: 
 <dev-return-40515-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org>
X-Original-To: apmail-couchdb-dev-archive@www.apache.org
Delivered-To: apmail-couchdb-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EC984CF6D
	for <apmail-couchdb-dev-archive@www.apache.org>;
 Thu, 25 Dec 2014 16:14:29 +0000 (UTC)
Received: (qmail 14034 invoked by uid 500); 25 Dec 2014 16:14:29 -0000
Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org
Received: (qmail 13972 invoked by uid 500); 25 Dec 2014 16:14:29 -0000
Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@couchdb.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@couchdb.apache.org>
List-Post: <mailto:dev@couchdb.apache.org>
List-Id: <dev.couchdb.apache.org>
Reply-To: dev@couchdb.apache.org
Delivered-To: mailing list dev@couchdb.apache.org
Received: (qmail 13959 invoked by uid 99); 25 Dec 2014 16:14:26 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Dec 2014 16:14:26 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 672F8A38814; Thu, 25 Dec 2014 16:14:26 +0000 (UTC)
From: robertkowalski <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-204-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-204-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: Update full page document
 editor
Content-Type: text/plain
Message-Id: <20141225161426.672F8A38814@tyr.zones.apache.org>
Date: Thu, 25 Dec 2014 16:14:26 +0000 (UTC)

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/204#discussion_r22274246
  
    --- Diff: app/addons/documents/templates/code_editor.html ---
    @@ -12,44 +12,64 @@
     the License.
     */%>
     
    -<div id="doc">
    -  <div class="errors-container"></div>
    -   
    -<div id="doc-actions" class="nav">
    -  <div class="span3">
    +<div id="doc-editor-actions-panel">
    +  <div class="doc-actions-left">
         <button class="save-doc btn btn-success save" type="button"><i class="icon fonticon-ok-circled"></i> Save</button>
    -    <button class="btn js-back">Back</button>
    +    <div>
    +      <a href="#" class="js-back cancel-button">Cancel</a>
    +    </div>
       </div>
     
    -  <div class="span7">
    -    <button class="btn string-edit" title="Edit line" disabled="true"><i class="icon icon-edit"></i></button>  
    +  <div class="alignRight">
    +    <button class="btn string-edit" title="Edit line" disabled="true"><i class="icon icon-edit"></i></button>
    +
         <% if (attachments) { %>
    -    <div class="btn-group">
    -      <button class="dropdown-toggle btn" data-bypass="true" data-toggle="dropdown">
    -        View Attachments
    +    <div class="panelSection btn-group">
    +      <button class="panelButton dropdown-toggle btn" data-bypass="true" data-toggle="dropdown" title="View Attachments"
    +        id="view-attachments-menu">
    +        <i class="icon fonticon-picture"></i>
    +        <span>View Attachments</span>
             <span class="caret"></span>
           </button>
    -      <ul class="dropdown-menu">
    +
    +      <ul class="dropdown-menu" role="menu" aria-labelledby="view-attachments-menu">
             <%_.each(attachments, function (att) { %>
             <li>
    -        <a href="<%- att.url %>" target="_blank" data-bypass="true"> <strong> <%- att.fileName %> </strong> -
    -          <span> <%- att.contentType %>, <%- formatSize(att.size)%> </span>
    -        </a>
    +          <a href="<%- att.url %>" target="_blank" data-bypass="true"> <strong> <%- att.fileName %> </strong> -
    +            <span> <%- att.contentType %>, <%- formatSize(att.size)%> </span>
    +          </a>
             </li>
             <% }) %>
           </ul>
         </div>
    -    <% } %> 
    -    <button class="btn upload"><i class="icon icon-circle-arrow-up"></i> Upload Attachment</button>
    -    <button class="btn duplicate"><i class="icon icon-repeat"></i> Clone document</button>
    -    <button class="btn btn-danger delete"><i class="icon icon-trash"></i></button>
    -  </div>
    +    <% } %>
     
    -<div id="upload-modal"> </div>
    -<div id="duplicate-modal"> </div> 
    -<div id="string-edit-modal"> </div> 
    --- End diff --
    
    please add it back, we should stay feature complete


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---