Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: kxepal <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-27-couchdb-couch@git.apache.org>
In-Reply-To: <git-pr-27-couchdb-couch@git.apache.org>
Subject: [GitHub] couchdb-couch pull request: Modify init_delete_dir to be
 async
Content-Type: text/plain
Message-Id: <20141219185756.869CBA2FDB3@tyr.zones.apache.org>
Date: Fri, 19 Dec 2014 18:57:56 +0000 (UTC)

Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/27#discussion_r22121802
  
    --- Diff: src/couch_file.erl ---
    @@ -260,10 +260,19 @@ init_delete_dir(RootDir) ->
         % note: ensure_dir requires an actual filename companent, which is the
         % reason for "foo".
         filelib:ensure_dir(filename:join(Dir,"foo")),
    --- End diff --
    
    Btw, there is no need to provide magic "foo" word here. Just let Dir trail with slash as directory paths have to be and it will works without magic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---