couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Update full page document editor
Date Thu, 25 Dec 2014 16:12:44 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/204#discussion_r22274235
  
    --- Diff: app/addons/documents/routes-doc-editor.js ---
    @@ -12,22 +12,22 @@
     
     define([
       "app",
    -
       "api",
     
       // Modules
    -  //views
    +  "addons/documents/helpers",
       "addons/documents/views",
       "addons/documents/views-doceditor",
       "addons/databases/base"
     ],
     
    -function(app, FauxtonAPI, Documents, DocEditor, Databases) {
    +function(app, FauxtonAPI, Helpers, Documents, DocEditor, Databases) {
    +
     
       var DocEditorRouteObject = FauxtonAPI.RouteObject.extend({
    -    layout: "one_pane",
    +    layout: 'doc_editor',
    --- End diff --
    
    please separate styling-commits from feature-commits, there is a lot of diff noise that
makes it hard to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message