couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davisp <...@git.apache.org>
Subject [GitHub] couchdb-couch pull request: Refactor couch_httpd_auth's AuthModule...
Date Fri, 05 Dec 2014 18:27:00 GMT
Github user davisp commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/21#discussion_r21389526
  
    --- Diff: src/couch_auth_cache.erl ---
    @@ -42,12 +43,18 @@
     
     
     -spec get_user_creds(UserName::string() | binary()) ->
    -    Credentials::list() | nil.
    -
    -get_user_creds(UserName) when is_list(UserName) ->
    -    get_user_creds(?l2b(UserName));
    +    {ok, Credentials::list(), term()} | nil.
     
     get_user_creds(UserName) ->
    +    get_user_creds(nil, UserName).
    +
    +-spec get_user_creds(Req::#httpd{}, UserName::string() | binary()) ->
    +    {ok, Credentials::list(), term()} | nil.
    +
    +get_user_creds(Req, UserName) when is_list(UserName) ->
    --- End diff --
    
    I was maintaining the line break as it existed. I can remove it if you so desire.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message