Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: hdiedrich <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
Message-ID: <git-pr-1-couchdb-snappy@git.apache.org>
Subject: [GitHub] couchdb-snappy pull request: Exclude ComputeTable from
 building
Content-Type: text/plain
Date: Fri, 14 Nov 2014 16:13:40 +0000 (UTC)

GitHub user hdiedrich opened a pull request:

    https://github.com/apache/couchdb-snappy/pull/1

    Exclude ComputeTable from building

    Set NDEBUG as CXXFLAGS to skip the compilation of this debug function.
    
    The NDEBUG logic is broken because REGISTER_MODULE_INITIALIZER(snappy,
    ComputeTable()); is set to always result to nothing, independently of
    NDEBUG.
    
    If debug tests should instead be included in the build, both NDEBUG
    must not be set (as before) but also, REGISTER_MODULE_INITIALIZER
    repaired.
    
    COUCHDB-2463

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hdiedrich/couchdb-snappy 2463-exclude-debug-function-computetable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-snappy/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
    
----
commit 80e7c4f23b25138d8670b16df3185f7960b25af4
Author: H. Diedrich <hdiedrich@eonblast.com>
Date:   2014-11-14T15:52:09Z

    Exclude ComputeTable from building
    
    Set NDEBUG as CXXFLAGS to skip the compilation of this debug function.
    
    The NDEBUG logic is broken because REGISTER_MODULE_INITIALIZER(snappy,
    ComputeTable()); is set to always result to nothing, independently of
    NDEBUG.
    
    If debug tests should instead be included in the build, both NDEBUG
    must not be set (as before) but also, REGISTER_MODULE_INITIALIZER
    repaired.
    
    COUCHDB-2463

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---