Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: robertkowalski <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-151-couchdb-fauxton@git.apache.org>
In-Reply-To: <git-pr-151-couchdb-fauxton@git.apache.org>
Subject: [GitHub] couchdb-fauxton pull request: Redesign Documents
Content-Type: text/plain
Message-Id: <20141119175045.A57209AC44C@tyr.zones.apache.org>
Date: Wed, 19 Nov 2014 17:50:45 +0000 (UTC)

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/151#discussion_r20593307
  
    --- Diff: app/addons/documents/tests/nightwatch/deletesDocument.js ---
    @@ -21,13 +21,14 @@ module.exports = {
           .loginToGUI()
           .createDocument(newDocumentName, newDatabaseName)
           .url(baseUrl)
    -      .waitForElementPresent('#dashboard-content a[href="#/database/'+newDatabaseName+'/_all_docs"]', waitTime, false)
    -      .pause(1000)
    +      .waitForElementPresent('#dashboard-content a[href="#/database/'+newDatabaseName+'/_all_docs"]', waitTime)
           .click('#dashboard-content a[href="#/database/'+newDatabaseName+'/_all_docs"]')
    -      .waitForElementPresent('[data-id="'+newDocumentName+'"] .btn.btn-small.btn-danger.delete', waitTime, false)
    -      .execute('$("[data-id=\''+newDocumentName+'\'] .btn.btn-small.btn-danger.delete").click();')
    +      .waitForElementVisible('label[for="checkbox-' + newDocumentName + '"]', waitTime)
    +      .click('label[for="checkbox-' + newDocumentName + '"]')
    +      .waitForElementPresent('.js-bulk-delete:not(.disabled)', waitTime)
    +      .click('button.js-bulk-delete')
           .acceptAlert()
    -      .waitForElementVisible('#global-notifications .alert.alert-info', waitTime, false)
    +      .waitForElementVisible('#global-notifications .alert.alert-info', waitTime)
    --- End diff --
    
    is there a reason not to fail fast if it is already broken at this step?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---