couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Move Helpers.docs into constants.js
Date Sat, 22 Nov 2014 01:00:14 GMT
GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/164

    Move Helpers.docs into constants.js

    This is a house cleaning ticket. It does a couple of things:
    1. Moves the list of URLs stored in Helpers.docs into constants.js
    2. Refactors constants to group the (now growing) list into appropriate
    groups.
    
    Now there are a lot less hardcoded "magic" strings throughout our
    code, yay!
    
    Closes COUCHDB-2474

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2474-helper-docs-moved-to-constants

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #164
    
----
commit 7db88f6cb806bae941393526fefbfe8ae68dd311
Author: Benjamin Keen <ben.keen@gmail.com>
Date:   2014-11-22T00:57:15Z

    Move Helpers.docs into constants.js
    
    This is a house cleaning ticket. It does a couple of things:
    1. Moves the list of URLs stored in Helpers.docs into constants.js
    2. Refactors constants to group the (now growing) list into appropriate
    groups.
    
    Now there are a lot less hardcoded "magic" strings throughout our
    code, yay!
    
    Closes COUCHDB-2474

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message