couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Write up expectations we have for co...
Date Sun, 02 Nov 2014 18:36:36 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/125

    Write up expectations we have for contributions

    We recently got a styleguide and we also have other expectations for contributions like
commit message char-length and a green passing testsuite, but it is not written up somewhere.
This costs time for the contributor and the reviewer.
    
    I changed our doc a bit which is also linked when you create a PR in a yellow box above
(`Please review the guidelines for contributing to this repository.`) and started to mention
the things that we expect:
     - mention styleguide
     - mention commit message format
    
    I also changed a point which did not make sense to me:
     - small bugfixes do not need a Jira ticket
    
    Summed up over a year it takes a lot of time to find each extra for a PR created Jira
ticket and close it, often people forget to close the ticket after the PR is merged (or do
not have the karma for it?). 
    
    My main reason for removing this rule is that we do not act to the rule in the project
- the theory differs a lot from the practical day-to-day business here. It also raises the
entry barrier for folks which just want to fix a small bug, but have to register an account
on Jira first, then verify their email, find out how to create a bug on Jira and then write
it and just after that are able to submit a patch for a bug.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb-fauxton contribing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit 87bbc0c9237015d78165a189dfc53bc21b8f209e
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-11-02T18:22:37Z

    Write up expectations we have for contributions
    
     - mention styleguide
     - mention commit message format
     - small bugfixes do not need a Jira ticket

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message