couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Move Helpers.docs into constants.js
Date Mon, 24 Nov 2014 16:35:26 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/164#discussion_r20801689
  
    --- Diff: app/addons/databases/resources.js ---
    @@ -31,8 +31,8 @@ function(app, FauxtonAPI, Documents) {
           });
         },
     
    -    documentation: function(){
    -      return "all_dbs";
    --- End diff --
    
    Ok, you make a valid point. Lets leave the FauxtonAPI.constants in then. Returning just
the `"all_docs"` does add a lot of magic which is probably unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message