couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Move Helpers.docs into constants.js
Date Mon, 24 Nov 2014 15:34:28 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/164#discussion_r20796698
  
    --- Diff: app/addons/fauxton/components.js ---
    @@ -239,7 +239,7 @@ function(app, FauxtonAPI, ace, spin, ZeroClipboard) {
     
         hideTray: function () {
           var $tray = this.$('.tray');
    -      $tray.velocity('reverse', FauxtonAPI.constants.TRAY_TOGGLE_SPEED, function () {
    +      $tray.velocity('reverse', FauxtonAPI.constants.MISC.TRAY_TOGGLE_SPEED, function
() {
    --- End diff --
    
    A bit of a nit pick. These fixes are unrelated to the docs helper. Try and avoid sneaking
fixes that are unrelated to the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message