couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Move Helpers.docs into constants.js
Date Mon, 24 Nov 2014 15:15:42 GMT
Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/164#discussion_r20795268
  
    --- Diff: app/addons/databases/resources.js ---
    @@ -31,8 +31,8 @@ function(app, FauxtonAPI, Documents) {
           });
         },
     
    -    documentation: function(){
    -      return "all_dbs";
    --- End diff --
    
    Yeah, this was my original concern with having to type out `FauxtonAPI.constants` instead
of just `C` or something. It got verbose awfully fast. 
    
    I don't have another solution other than storing the var in a local var to reduce the
length, or maybe renaming the main constants var to `FauxtonAPI.C`. Meh. :(
    
    But personally I don't think this is all that bad. It's certainly verbose but clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message