couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Move Helpers.docs into constants.js
Date Mon, 24 Nov 2014 09:42:43 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/164#discussion_r20780027
  
    --- Diff: app/addons/databases/resources.js ---
    @@ -31,8 +31,8 @@ function(app, FauxtonAPI, Documents) {
           });
         },
     
    -    documentation: function(){
    -      return "all_dbs";
    --- End diff --
    
    I like the idea of the docs being in `constants.js` but I don't like that we have to go
from `"all_dbs"` to `FauxtonAPI.constants.DOC_URLS.ALL_DBS` everytime we want a documentation
string. Could we not have a way of mapping the doc strings so that we don't have to do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message