couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michellephung <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: [WIP] Nightwatch test to test lookah...
Date Fri, 21 Nov 2014 07:29:32 GMT
Github user michellephung commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/160#issuecomment-63933602
  
    Finally found it. I'm so sorry.
    
    The clickable part is hidden behind the 'You are now logged in.' banner.
    
    In loginToGUI.js, I used a jQuery injection to dismiss the modal (line 13), but I left
out a line. 
    
    The solution is to add 
    > .waitForElementVisible("#global-notifications", 8000, false)
    
    before the jQuery injection (to line 13, in loginToGUI.js). With this change, your test
passes without the 5-second pause.
    
    I can add this tomorrow. 
    
    It will let me use a .click() event instead of an using .execute() on the page in one
of my other tests, so I'm excited.
    
    However, it did remind me about the concerns about injecting javascript into the page.
As I was testing the script, I wondered if having .execute('$(button).click();') functions
in the tests would be a bad example for future coders. We would have to wait an extra 5 seconds
on every test unless we bring back the 'close modal' button.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message