couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Shouldn't throw Ace Editor js error
Date Wed, 19 Nov 2014 00:56:44 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/159#discussion_r20551658
  
    --- Diff: app/addons/documents/tests/nightwatch/navigateToNewView.js ---
    @@ -0,0 +1,37 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +module.exports = {
    +
    +  // this tests that the user is able to just navigate to and from the New View page
without errors [it confirms
    +  // a bug fix for where the Ace Editor threw a JS error preventing the subsequent page
from loading]
    +  'Navigate to and from New View Page' : function (client) {
    +    /*jshint multistr: true */
    +    var waitTime = 10000,
    +      newDatabaseName = client.globals.testDatabaseName,
    +      baseUrl = client.globals.baseUrl;
    +
    +    client
    +      .loginToGUI()
    +      .url(baseUrl+'/#/database/'+newDatabaseName+'/_all_docs')
    --- End diff --
    
    can you add a space between the `+`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message