couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KlausTrainer <>
Subject [GitHub] couchdb pull request: Use cookie authentication during replication
Date Tue, 18 Nov 2014 18:06:00 GMT
Github user KlausTrainer commented on a diff in the pull request:
    --- Diff: src/couch_replicator/src/couch_replicator_api_wrap.hrl ---
    @@ -24,7 +24,10 @@
         retries = 10,
         wait = 250,         % milliseconds
         httpc_pool = nil,
    -    http_connections
    +    http_connections,
    +    root_url,           % e.g. ""
    +    credentials         % ets table for storing the basic auth
    --- End diff --
    There's another consideration that I forgot about, until Robert Kowalski
    brought it back to my awareness in a conversation we had yesterday.
    Using an ETS table for keeping credentials has the important benefit of
    avoiding that those will appear in stack traces.  Although one could use
    the `sensitive` process flag to achieve the same, we probably don't want
    to do that, as it entails disadvantages with regard to tracing and
    debugging the respective process (see

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message