couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rnewson <...@git.apache.org>
Subject [GitHub] couchdb pull request: Use cookie authentication during replication
Date Wed, 12 Nov 2014 19:08:20 GMT
Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/278#discussion_r20241954
  
    --- Diff: src/couchdb/couch_httpd_auth.erl ---
    @@ -188,8 +188,12 @@ cookie_authentication_handler(#httpd{mochi_req=MochiReq}=Req) ->
                     FullSecret = <<Secret/binary, UserSalt/binary>>,
                     ExpectedHash = crypto:sha_mac(FullSecret, User ++ ":" ++ TimeStr),
                     Hash = ?l2b(HashStr),
    -                Timeout = list_to_integer(
    +                ConfiguredTimeout = list_to_integer(
                         couch_config:get("couch_httpd_auth", "timeout", "600")),
    +                Timeout = case ConfiguredTimeout < 60 of
    --- End diff --
    
    suggest lists:min([ConfiguredTimeout, 60])
    
    but I think this min of 60s is because of the earlier code that changes the cookie based
on interval and not when the response updates it, so perhaps this change is moot after addressing
the previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message