couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: grunt works :) with $ grunt nightwat...
Date Thu, 06 Nov 2014 15:51:21 GMT
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/136#issuecomment-61999432
  
    Wow, awesome work, kudos!
    
    I noticed some small things: 
    
     - please document how to run the tests and that they need an admin user tester:testpass
and how to run a single test at  https://github.com/apache/couchdb-fauxton#running-tests
    
     - please recheck the committed files. We use 2 spaces as intendation, single quotes and
it is good behaviour to end files with a newline (files that miss a newline at the end-of-file
are marked in the diff with a red sign at the end of file in https://github.com/apache/couchdb-fauxton/pull/136/files).
    
     - some tests make use of hardcoded sync timeouts (`.pause()`) where a `waitForElementVisible
` and friends might save time and/or reduce flakyness
    
     - http://localhost:8000 is hardcoded in alot of files - can you move it to helpers?
    
     - The signature of a command is `exports.command = function(file, callback) {` - and
nano is working async. Instead of waiting one second I would call  the callback inside the
callback of nano and remove the pause. I will add two comments to two of the commands that
explain async commands.
    
    - why is the `Helpers` folder starting with a capital letter? can we lowercase it like
the others?
    
    - I don't think we should check in selenium and chromedriver into the repository but download
them instead if they are not there. The binaries should not be part of a couchdb-release and
by just downloading them on demand we don't have to add them to our license file. Let's double
check and ask in #couchdb-dev today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message