couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: [WIP] Initial version of an all-purp...
Date Mon, 03 Nov 2014 03:15:55 GMT
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/119#issuecomment-61436907
  
    Great solution, @robertkowalski. Merged. 
    
    One final thing before this PR is okay to merge. I added the `this.allDatabases.fetchOnce()`
right in the main `establish` method of the route object, which means every time you get to
the page it makes that request. I was thinking of moving that to be more on-demand so that
it only makes the request after the tray is opened (I'd add a spinner or something). Usability
may suffer a little, but it would spare on a request. What are your thoughts? Do you think
the extra request matters?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message