Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 07B3F17731 for ; Tue, 28 Oct 2014 14:28:30 +0000 (UTC) Received: (qmail 57339 invoked by uid 500); 28 Oct 2014 14:28:29 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 57280 invoked by uid 500); 28 Oct 2014 14:28:29 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 57269 invoked by uid 99); 28 Oct 2014 14:28:29 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 14:28:29 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id DE309992D14; Tue, 28 Oct 2014 14:28:28 +0000 (UTC) From: benkeen To: dev@couchdb.apache.org Reply-To: dev@couchdb.apache.org References: In-Reply-To: Subject: [GitHub] couchdb-fauxton pull request: Added constants.js file to core Content-Type: text/plain Message-Id: <20141028142828.DE309992D14@tyr.zones.apache.org> Date: Tue, 28 Oct 2014 14:28:28 +0000 (UTC) Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/111#issuecomment-60763703 I'd say merge it in now. We can easily switch out the hardcoded vars later in our day-to-day PRs. Basically I was hoping to use this for all script-wide "magic" strings: common events, authentication roles, you name it. I think there's great value in having such things identified in a single place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---