couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Fix rendering on view-list after cre...
Date Tue, 28 Oct 2014 15:09:14 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/114

    Fix rendering on view-list after creating a view

    AllDocsList is lazily adding subviews in the `beforeRender` method,
    which causes that it will throw an error for all methods that
    access these subviews from outside before explicitly rendering
    the view.
    
    As the beforeRender is adding paging, subviews, and the establish
    takes care of our collection, we are fine with just rendering.
    
    After we got this working, we can navigate without a
    `trigger: false` and are getting a view on the indexed doc after
    creating the view.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb-fauxton fix-redirect-after-design-doc-creation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #114
    
----
commit 7dbb39b811178a52b76196b429dcdaf16d7f67d4
Author: Robert Kowalski <robertkowalski@apache.org>
Date:   2014-10-28T14:54:02Z

    Fix rendering on view-list after creating a view
    
    AllDocsList is lazily adding subviews in the `beforeRender` method,
    which causes that it will throw an error for all methods that
    access these subviews from outside before explicitly rendering
    the view.
    
    As the beforeRender is adding paging, subviews, and the establish
    takes care of our collection, we are fine with just rendering.
    
    After we got this working, we can navigate without a
    `trigger: false` and are getting a view on the indexed doc after
    creating the view.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message