couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-708) Newlines in document locations break header parsing
Date Thu, 30 Oct 2014 14:28:34 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190122#comment-14190122
] 

ASF subversion and git services commented on COUCHDB-708:
---------------------------------------------------------

Commit 9ee298ff0af335f7449eca0f839caf0c5646887a in couchdb-couch's branch refs/heads/master
from [~robertkowalski]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=9ee298f ]

Fix header for documents with newlines in the name

Properly urlencode the Document-Id in the Location field of the
header

Based on a patch from Sean Bartell <wingedtachikoma@gmail.com>

Added some eunit-tests

COUCHDB-708


> Newlines in document locations break header parsing
> ---------------------------------------------------
>
>                 Key: COUCHDB-708
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-708
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>    Affects Versions: 0.10.1
>         Environment: ubuntu
>            Reporter: Tim
>            Assignee: Robert Kowalski
>            Priority: Critical
>         Attachments: couchdb-urlencode-location.patch
>
>
> Newlines in document locations break header parsing. Potential header injection issues?
> $ curl -X DELETE http://localhost:5984/testdb
> {"ok":true}
> $ curl -X PUT http://localhost:5984/testdb
> {"ok":true}
> $ curl -i -X PUT -d '{}' 'http://localhost:5984/testdb/docid%0A'
> HTTP/1.1 201 Created
> Server: CouchDB/0.10.1 (Erlang OTP/R13B)
> Location: http://localhost:5984/testdb/docid
> Etag: "1-967a00dff5e02add41819138abb3284d"
> Date: Wed, 24 Mar 2010 12:33:25 GMT
> Content-Type: text/plain;charset=utf-8
> Content-Length: 70
> Cache-Control: must-revalidate
> {"ok":true,"id":"docid\n","rev":"1-967a00dff5e02add41819138abb3284d"}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message