couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-708) Newlines in document locations break header parsing
Date Sat, 25 Oct 2014 13:29:34 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184091#comment-14184091
] 

ASF GitHub Bot commented on COUCHDB-708:
----------------------------------------

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/275

    Add integration-test for newlines in location header

    COUCHDB-708

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb 708-newline-header

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #275
    
----
commit d150a8ea75eab63c8af0f4cbfd360e174d8d703a
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-10-25T13:26:11Z

    Add integration-test for newlines in location header
    
    COUCHDB-708

----


> Newlines in document locations break header parsing
> ---------------------------------------------------
>
>                 Key: COUCHDB-708
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-708
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>    Affects Versions: 0.10.1
>         Environment: ubuntu
>            Reporter: Tim
>            Assignee: Robert Kowalski
>            Priority: Critical
>         Attachments: couchdb-urlencode-location.patch
>
>
> Newlines in document locations break header parsing. Potential header injection issues?
> $ curl -X DELETE http://localhost:5984/testdb
> {"ok":true}
> $ curl -X PUT http://localhost:5984/testdb
> {"ok":true}
> $ curl -i -X PUT -d '{}' 'http://localhost:5984/testdb/docid%0A'
> HTTP/1.1 201 Created
> Server: CouchDB/0.10.1 (Erlang OTP/R13B)
> Location: http://localhost:5984/testdb/docid
> Etag: "1-967a00dff5e02add41819138abb3284d"
> Date: Wed, 24 Mar 2010 12:33:25 GMT
> Content-Type: text/plain;charset=utf-8
> Content-Length: 70
> Cache-Control: must-revalidate
> {"ok":true,"id":"docid\n","rev":"1-967a00dff5e02add41819138abb3284d"}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message