couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rnewson <...@git.apache.org>
Subject [GitHub] couchdb-couch pull request: Implement two factor authentication
Date Fri, 31 Oct 2014 11:18:20 GMT
Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/12#discussion_r19661642
  
    --- Diff: src/couch_httpd_auth.erl ---
    @@ -430,3 +432,48 @@ max_age() ->
                     config:get("couch_httpd_auth", "timeout", "600")),
                 [{max_age, Timeout}]
         end.
    +
    +reject_if_totp(User) ->
    +    case get_totp_config(User) of
    +        undefined ->
    +            ok;
    +        _ ->
    +            throw({unauthorized, <<"Name or password is incorrect.">>})
    +    end.
    +
    +verify_totp(User, Form) ->
    +    case get_totp_config(User) of
    +        undefined ->
    +            ok;
    +        {Props} ->
    +            Key = couch_util:get_value(<<"key">>, Props),
    +            Alg = couch_util:to_existing_atom(
    +                couch_util:get_value(<<"algorithm">>, Props, <<"sha">>)),
    +            Len = couch_util:get_value(<<"length">>, Props, 6),
    +            Token = ?l2b(couch_util:get_value("token", Form, "")),
    +            verify_token(Alg, Key, Len, Token)
    +    end.
    +
    +get_totp_config(User) ->
    +    couch_util:get_value(<<"totp">>, User).
    +
    +verify_token(Alg, Key, Len, Token) ->
    +    Now = make_cookie_time(),
    +    Tokens = [generate_token(Alg, Key, Len, Now - 30),
    --- End diff --
    
    I left the skew unconfigurable for now. It seems this 90 second thing is quite standard.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message