couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rnewson <...@git.apache.org>
Subject [GitHub] couchdb-couch pull request: Implement two factor authentication
Date Thu, 30 Oct 2014 12:49:48 GMT
Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/12#discussion_r19602140
  
    --- Diff: src/couch_httpd_auth.erl ---
    @@ -430,3 +432,45 @@ max_age() ->
                     config:get("couch_httpd_auth", "timeout", "600")),
                 [{max_age, Timeout}]
         end.
    +
    +reject_if_two_factor(User) ->
    +    case get_two_factor_config(User) of
    +        undefined ->
    +            ok;
    +        _ ->
    +            throw({unauthorized, <<"Name or password is incorrect.">>})
    +    end.
    +
    +verify_two_factor(User, Form) ->
    +    case get_two_factor_config(User) of
    +        undefined ->
    +            ok;
    +        {Props} ->
    +            Key = couch_util:get_value(<<"key">>, Props),
    +            Token = ?l2b(couch_util:get_value("token", Form, "")),
    +            verify_token(Key, Token)
    +    end.
    +
    +get_two_factor_config(User) ->
    +    couch_util:get_value(<<"2f">>, User).
    --- End diff --
    
    yeah, I wasn't sure on the name so I just put something short. I was thinking of a "2f":
{"type":"totp","key":"hello"} thing so we're not tied to totp algorithm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message