couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb-couch pull request: Implement two factor authentication
Date Thu, 30 Oct 2014 10:59:14 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/12#discussion_r19597850
  
    --- Diff: src/couch_totp.erl ---
    @@ -0,0 +1,23 @@
    +% Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +% use this file except in compliance with the License. You may obtain a copy of
    +% the License at
    +%
    +%   http://www.apache.org/licenses/LICENSE-2.0
    +%
    +% Unless required by applicable law or agreed to in writing, software
    +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +% License for the specific language governing permissions and limitations under
    +% the License.
    +
    +-module(couch_totp).
    +
    +-export([generate/3, generate/4]).
    +
    +generate(Key, CounterSecs, StepSecs) ->
    +    generate(Key, CounterSecs, StepSecs, 8).
    +
    +generate(Key, CounterSecs, StepSecs, OutputLen)
    +  when is_binary(Key), is_integer(CounterSecs), is_integer(StepSecs),
    --- End diff --
    
    Won't such defensive policy cause overhead since you have the same guard for `couch_hotp:generate`.
Also, may be add fallback `generate` for both modules to handle bad arguments in more friendly
way?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message