couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Fix rendering on view-list after cre...
Date Tue, 28 Oct 2014 18:25:55 GMT
Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/114#discussion_r19492546
  
    --- Diff: app/addons/documents/routes-documents.js ---
    @@ -355,10 +355,13 @@ function(app, FauxtonAPI, Documents, Changes, Index, DocEditor,
Databases, Resou
               urlParams = params.urlParams,
               docParams = params.docParams,
               ddoc = event.ddoc,
    +          defaultPageSize,
    +          isLazyInit,
               pageSize,
               collection;
     
    -      var defaultPageSize = _.isUndefined(this.documentsView) ? 20 : this.documentsView.perPage();
    +      isLazyInit = _.isUndefined(this.documentsView) || _.isUndefined(this.documentsView.allDocsNumber);
    +      defaultPageSize = isLazyInit ? 20 : this.documentsView.perPage();
    --- End diff --
    
    Maybe 20 should be a constant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message