couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Prevent double query submission 2nd ...
Date Fri, 17 Oct 2014 21:45:18 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/104#discussion_r19045448
  
    --- Diff: app/addons/documents/views-queryoptions.js ---
    @@ -107,6 +107,8 @@ define([
             if (!this.trayIsVisible()) {
               $("#query-options-tray").velocity("transition.slideDownIn", 250); // TODO constant
               FauxtonAPI.Events.trigger("APIbar:closeTray");
    +          // make sure the query button is active again. As we can only expand for completed
results, this is sufficient to prevent double submission
    +          $("#query-options-tray button[type=\"submit\"]").removeAttr("disabled");
    --- End diff --
    
    You do not need to escape the `"`- just mix single and double quotes - you can also use
`this.$` to explicitly access the elements that are in this view, so people do not get confused
which element in the DOM you are manipulating:
    
    `this.$('#query-options-tray button[type="submit"]').removeAttr("disabled");`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message