couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: login page auto-focus on username fi...
Date Fri, 10 Oct 2014 22:57:45 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/89#discussion_r18735252
  
    --- Diff: app/addons/auth/resources.js ---
    @@ -33,15 +33,12 @@ function (app, FauxtonAPI, CouchdbSession) {
       };
     
       var Admin = Backbone.Model.extend({
    -
    -    url: function () {
    +    url: function() {
           return app.host + '/_config/admins/' + this.get("name");
         },
    -
    -    isNew: function () { return false; },
    +    isNew: function() { return false; },
    --- End diff --
    
    why do you change them all back? garren and me write our functions like this, probably
we all should work out a coding style doc for the future


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message