couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Fix works, but no tests yet.
Date Mon, 06 Oct 2014 21:34:34 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/80#discussion_r18487333
  
    --- Diff: app/addons/auth/templates/noAccess.html ---
    @@ -16,6 +16,12 @@
       <h2>Access Denied</h2>
       <p>
         You do not have permission to view this page.<br />
    -    You might need to <a href="#login<% if (urlBack){ %>?urlback=<%=urlBack%>
 <% } %> ">login</a>.
    +
    +    <% if (user) { %>
    +      If you need access, you'll have to request authorisation for this resource from
an admin.
    +    <% } else { %>
    +      You might need to <a href="#login<% if (urlBack){ %>?urlback=<%=urlBack%>
 <% } %> ">login</a>.
    --- End diff --
    
    About the first: good point. Agreed. 
    
    About the second: probably not in this sentence, but in the following one like "← Back"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message