couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: New Query Options tray added
Date Mon, 06 Oct 2014 10:11:53 GMT
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/78#issuecomment-57997586
  
    @benkeen this is fantastic work. You have made a section of our code that was rather ugly
into something great. I really like this.
    
    One thing though is that I'm not sure you should pass the `rightHeader` into the `ViewEditor`
view (I have a feeling I might have asked you to do this in the beginning but I now realise
its not great). I think we should rather fire a routeObject event, like we do for `route:updateAllDocs`,
when we want the query options to change because of a `ViewEditor` change. We should only
pass views into other viewsif they are genuine sub-views.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message