couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From benkeen <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: New Query Options tray added
Date Sat, 04 Oct 2014 16:52:31 GMT
Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/78#discussion_r18430231
  
    --- Diff: app/addons/documents/routes-documents.js ---
    @@ -333,16 +324,20 @@ function(app, FauxtonAPI, Documents, Changes, Index, DocEditor,
Databases, Resou
           this.documentsView && this.documentsView.remove();
     
           this.viewEditor = this.setView("#dashboard-upper-content", new Index.ViewEditor({
    -        currentddoc: "_design/"+designDoc || "",
    +        rightHeaderView: this.rightHeader,
    +        currentddoc: "_design/" + designDoc || "",
             ddocs: this.designDocs,
             params: params,
             database: this.database,
             newView: true
           }));
     
    -      this.sidebar.setSelectedTab('new-view');
    +      this.sidebar.setSelectedTab("new-view");
    +      this.rightHeader.hideQueryOptions();
     
    -      //this.rightHeader.updateApiUrl([this.indexedDocs.urlRef("apiurl", urlParams),
"docs"]);
    +      // TODO
    +//      var apiUrl = this.database.url("app") + "/new_view/" + designDoc;
    --- End diff --
    
    As well you might! l'll remove the changed lines. To explain: this was originally commented
out - I didn't add/remove any code. I'd noticed that the content of the API Url didn't seem
to be correct for that route. 
    
    But I figured it was out of scope for this ticket, so I just put the "TODO" so I wouldn't
forget. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message