couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: New Query Options tray added
Date Fri, 03 Oct 2014 19:09:05 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/78#discussion_r18413702
  
    --- Diff: app/addons/documents/views-queryoptions.js ---
    @@ -0,0 +1,522 @@
    +// Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +// use this file except in compliance with the License. You may obtain a copy of
    +// the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing, software
    +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +// License for the specific language governing permissions and limitations under
    +// the License.
    +
    +define([
    +  "app",
    +  "api",
    +
    +  // libs
    +  "addons/fauxton/resizeColumns"
    +],
    +
    +function(app, FauxtonAPI) {
    +
    +
    +  // our default settings for the Query Options tray
    +  var defaultOptions = {
    +    showStale: false,
    +    hasReduce: false,
    +
    +    // all the possible query search params. Ultimately these should probably be moved
higher-up (route object?),
    +    // because they also apply to the actual search results. Seems better to place them
there, then use them in
    +    // both places
    +    queryParams: {
    +      include_docs: "false",
    +      keys: "",
    +      limit: "",
    +      descending: "false",
    +      skip: "",
    +      update_seq: "false",
    +      startkey: "",
    +      endkey: "",
    +      inclusive_end: "true",
    +      reduce: "false",
    +      stale: "",
    +      group_level: "999" // TODO the doc says I can pass group_level=exact, but it doesn't
work
    --- End diff --
    
    I believe docs you're referenced is http://docs.couchdb.org/en/latest/couchapp/views/intro.html?highlight=group_level#the-view-to-get-comments-for-posts
(and a bit below)?
    
    Not sure, but group_level=exact is a legacy thing that isn't actual any more (btw. nice
found!). It origins to https://github.com/apache/couchdb-couch-mrview/blob/master/src/couch_mrview_http.erl#L397
and as you see `group=true` is actually sets special value `exact` for `group_level` field
but in the same time parser requires `group_level` query parameter to have integer value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message