couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Added missing API link to header of ...
Date Mon, 22 Sep 2014 07:49:30 GMT
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/60#issuecomment-56339457
  
    @benkeen thanks for trying to fix this. That fix is not quite right. The way to fix this
is actually just to add a `masterLayout.apiBar.show();` after this line https://github.com/apache/couchdb-fauxton/blob/master/app/addons/fauxton/base.js#L88
    
    How this section works is that in each RouteObject we have a `apiUrl` function which has
a documentation link and a raw api link. In the fauxton module we listen for the routeObject
`renderComplete` event. We look at the routeObject and see if it has a `apiUrl` function and
then render the api url for the page.
    
    @robertkowalski only on the database page do we have two api bars. Its definitely not
ideal and in the long term we must fix it. But we can only do that once we have moved all
the components from #31 into master. Then we can refactor some of those new components to
use the single master api bar like it use to be. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message