couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb-fauxton pull request: Secondary indexes: huge branch
Date Tue, 19 Aug 2014 10:26:56 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/33#discussion_r16406736
  
    --- Diff: app/addons/documents/routes.js ---
    @@ -348,40 +392,18 @@ function(app, FauxtonAPI, Documents, Changes, Index, DocEditor,
Databases, Resou
           };
         },
     
    -    createViewDocumentsView: function (options) {
    -
    -      return this.setView("#dashboard-lower-content", new Documents.Views.AllDocsList({
    -        database: options.database,
    -        collection: options.indexedDocs,
    -        nestedView: Documents.Views.Row,
    -        viewList: true,
    -        ddocInfo: this.ddocInfo(options.designDoc, options.designDocs, options.view),
    -        docParams: options.docParams,
    -        params: options.urlParams
    -      }));
    -    },
    -
    -    newViewEditor: function (database, designDoc) {
    -      var params = app.getParams();
    -
    -      this.toolsView && this.toolsView.remove();
    -      this.documentsView && this.documentsView.remove();
    -
    -      this.viewEditor = this.setView("#dashboard-upper-content", new Index.ViewEditor({
    -        currentddoc: "_design/"+designDoc || "",
    -        ddocs: this.data.designDocs,
    -        params: params,
    -        database: this.data.database,
    -        newView: true
    -      }));
    +    // createViewDocumentsView: function (options) {
     
    -      this.sidebar.setSelectedTab('new-view');
    -      this.crumbs = function () {
    -        return [
    -          {"name": this.data.database.id, "link": Databases.databaseUrl(this.data.database)},
    -        ];
    -      };
    -    },
    +    //   return this.setView("#dashboard-lower-content", new Documents.Views.AllDocsList({
    +    //     database: options.database,
    --- End diff --
    
    Probably don't need this code if its commented out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message