Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: chewbranca <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-253-couchdb@git.apache.org>
In-Reply-To: <git-pr-253-couchdb@git.apache.org>
Subject: [GitHub] couchdb pull request: Replace etap tests with eunit
Content-Type: text/plain
Message-Id: <20140714204050.8C291931D71@tyr.zones.apache.org>
Date: Mon, 14 Jul 2014 20:40:50 +0000 (UTC)

Github user chewbranca commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/253#discussion_r14902233
  
    --- Diff: src/couch_replicator/test/couch_replicator_compact_tests.erl ---
    @@ -0,0 +1,448 @@
    +% Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +% use this file except in compliance with the License. You may obtain a copy of
    +% the License at
    +%
    +%   http://www.apache.org/licenses/LICENSE-2.0
    +%
    +% Unless required by applicable law or agreed to in writing, software
    +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +% License for the specific language governing permissions and limitations under
    +% the License.
    +
    +-module(couch_replicator_compact_tests).
    +
    +-include("couch_eunit.hrl").
    +-include_lib("couchdb/couch_db.hrl").
    +-include_lib("couch_replicator/src/couch_replicator.hrl").
    +
    +-define(ADMIN_ROLE, #user_ctx{roles=[<<"_admin">>]}).
    +-define(ADMIN_USER, {user_ctx, ?ADMIN_ROLE}).
    +-define(ATTFILE, filename:join([?FIXTURESDIR, "logo.png"])).
    +-define(DELAY, 100).
    +-define(TIMEOUT, 30000).
    +-define(TIMEOUT_STOP, 1000).
    +-define(TIMEOUT_WRITER, 3000).
    +-define(TIMEOUT_EUNIT, ?TIMEOUT div 1000 + 5).
    +
    +setup() ->
    +    DbName = ?tempdb(),
    +    {ok, Db} = couch_db:create(DbName, [?ADMIN_USER]),
    +    ok = couch_db:close(Db),
    +    DbName.
    +
    +setup(local) ->
    +    setup();
    +setup(remote) ->
    +    {remote, setup()};
    +setup({A, B}) ->
    +    {ok, _} = couch_server_sup:start_link(?CONFIG_CHAIN),
    +    Source = setup(A),
    +    Target = setup(B),
    +    {Source, Target}.
    +
    +teardown({remote, DbName}) ->
    +    teardown(DbName);
    +teardown(DbName) ->
    +    ok = couch_server:delete(DbName, [?ADMIN_USER]),
    +    ok.
    +
    +teardown(_, {Source, Target}) ->
    +    teardown(Source),
    +    teardown(Target),
    +
    +    Pid = whereis(couch_server_sup),
    +    erlang:monitor(process, Pid),
    +    couch_server_sup:stop(),
    +    receive
    +        {'DOWN', _, _, Pid, _} ->
    +            ok
    +    after ?TIMEOUT_STOP ->
    +        throw({timeout, server_stop})
    +    end.
    +
    +
    +compact_test_() ->
    +    Pairs = [{local, local}, {local, remote},
    +             {remote, local}, {remote, remote}],
    +    {
    +        "Compaction during replication tests",
    +        {
    +            foreachx,
    +            fun setup/1, fun teardown/2,
    +            [{Pair, fun should_populate_replicate_compact/2}
    +             || Pair <- Pairs]
    +        }
    +    }.
    +
    +
    +should_populate_replicate_compact({From, To}, {Source, Target}) ->
    +    {ok, RepPid, RepId} = replicate(Source, Target),
    +    {lists:flatten(io_lib:format("~p -> ~p", [From, To])),
    +     {inorder, [
    +         should_run_replication(RepPid, RepId, Source, Target),
    +         should_all_processes_be_alive(RepPid, Source, Target),
    +         should_populate_and_compact(RepPid, Source, Target, 50, 5),
    +         should_wait_target_in_sync(Source, Target),
    +         should_ensure_replication_still_running(RepPid, RepId, Source, Target),
    +         should_cancel_replication(RepId, RepPid),
    +         should_compare_databases(Source, Target)
    +     ]}}.
    +
    +should_all_processes_be_alive(RepPid, Source, Target) ->
    +    ?_test(begin
    +        {ok, SourceDb} = reopen_db(Source),
    +        {ok, TargetDb} = reopen_db(Target),
    +        ?assert(is_process_alive(RepPid)),
    +        ?assert(is_process_alive(SourceDb#db.main_pid)),
    +        ?assert(is_process_alive(TargetDb#db.main_pid))
    +    end).
    +
    +should_run_replication(RepPid, RepId, Source, Target) ->
    +    ?_test(check_active_tasks(RepPid, RepId, Source, Target)).
    +
    +should_ensure_replication_still_running(RepPid, RepId, Source, Target) ->
    +    ?_test(check_active_tasks(RepPid, RepId, Source, Target)).
    --- End diff --
    
    What's the purpose of having `should_run_replication/4` and `should_ensure_replication_still_running`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---