couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb pull request: Replace etap tests with eunit
Date Wed, 02 Jul 2014 22:34:01 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/253#discussion_r14488175
  
    --- Diff: src/couch_mrview/test/couch_mrview_all_docs_tests.erl ---
    @@ -48,10 +81,9 @@ test_basic(Db) ->
             mk_row(<<"9">>, <<"1-558c8487d9aee25399a91b5d31d90fe2">>),
             mk_row(<<"_design/bar">>, <<"1-a44e1dd1994a7717bf89c894ebd1f081">>)
         ]},
    -    etap:is(Result, Expect, "Simple view query worked.").
    +    ?_assertEqual(Expect, Result).
     
    -
    -test_range(Db) ->
    +should_query_with_range(Db) ->
    --- End diff --
    
    That would require to rename all the functions since they all returns generators except
few ones which are too basic or runs uncommon case. Is there any profit in? You'll easily
notice the kind of function by the place where it's defined.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message