couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chewbranca <...@git.apache.org>
Subject [GitHub] couchdb pull request: Replace etap tests with eunit
Date Wed, 02 Jul 2014 22:20:07 GMT
Github user chewbranca commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/253#discussion_r14487540
  
    --- Diff: src/couch_mrview/test/couch_mrview_all_docs_tests.erl ---
    @@ -13,26 +10,62 @@
     % License for the specific language governing permissions and limitations under
     % the License.
     
    -main(_) ->
    -    test_util:run(6, fun() -> test() end).
    +-module(couch_mrview_all_docs_tests).
    +
    +-include("couch_eunit.hrl").
    +-include_lib("couchdb/couch_db.hrl").
    +
    +-define(ADMIN_USER, {user_ctx, #user_ctx{roles=[<<"_admin">>]}}).
    +-define(TIMEOUT, 1000).
     
     
    -test() ->
    -    couch_server_sup:start_link(test_util:config_files()),
    +start() ->
    +    {ok, Pid} = couch_server_sup:start_link(?CONFIG_CHAIN),
    --- End diff --
    
    Similarly, it would be good to have a generic `start_couch` function in a test util file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message