Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: garrensmith <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-251-couchdb@git.apache.org>
In-Reply-To: <git-pr-251-couchdb@git.apache.org>
Subject: [GitHub] couchdb pull request: 2160 string edit
Content-Type: text/plain
Message-Id: <20140623084850.C0639886F4D@tyr.zones.apache.org>
Date: Mon, 23 Jun 2014 08:48:50 +0000 (UTC)

Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/251#discussion_r14065498
  
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -765,6 +805,46 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb,
           FauxtonAPI.navigate(this.database.url("index") + "?limit=100");
         },
     
    +    determineStringEditMatch: function(event) {
    +      var selStart = this.editor.editor.getSelectionRange().start.row;
    +      var selEnd = this.editor.editor.getSelectionRange().end.row;
    +      if (selStart >=0 && selEnd >= 0 && selStart == selEnd) {
    --- End diff --
    
    Could you make that a `===` instead of `==`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---