couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb pull request: 2160 string edit
Date Mon, 30 Jun 2014 08:58:15 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/251#discussion_r14340747
  
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -765,6 +804,62 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb,
           FauxtonAPI.navigate(this.database.url("index") + "?limit=100");
         },
     
    +    determineStringEditMatch: function(event) {
    +      var selStart = this.editor.getSelectionStart().row;
    +      var selEnd = this.editor.getSelectionEnd().row;
    +      /* one JS(ON) string can't span more than one line - we edit one string, so ensure
we don't select several lines */
    +      if (selStart >=0 && selEnd >= 0 && selStart === selEnd &&
this.editor.isRowExpanded(selStart)) {    
    +        var editLine = this.editor.getLine(selStart);
    +	var editMatch = editLine.match(/^([ \t]*)("[a-zA-Z0-9_]*": )?(".*",?[ \t]*)$/);
    +	if (editMatch) {
    +          return editMatch;
    +	} else {
    +          return null;
    +	}
    +      } else {
    +        return null;
    +      }
    +    }, 
    +
    +    showHideEditDocString: function (event) {
    +      this.$("button.string-edit").attr("disabled", "true");
    +      if (!this.hasValidCode()) {
    +        return false;
    +      }
    +      var editMatch = this.determineStringEditMatch(event);
    +      if (editMatch) {
    +        this.$("button.string-edit").removeAttr("disabled");
    +	/* remove the following lines (along with CSS) to go back to the toolbar */
    +        this.$("button.string-edit").css("position", "absolute");
    --- End diff --
    
    Is it not possible to make this css a class we just add to the `.string-edit` when we
show or hide it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message