couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: New document sidebar
Date Mon, 23 Jun 2014 14:02:12 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/248#discussion_r14076311
  
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -42,7 +43,6 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb,
         });
       }
     
    -  var Views = {};
    --- End diff --
    
    > I don't quite follow what you mean here? Do you want to add views.js as a dependancy
to sidebarviews.js? 
    
    Yes, what do you think about this approach?
    
    Loading everything into one View Object reminds me that this could lead to `God Objects`
and Global State plus dependency issues (`sidebarviews.js` which is a depenency of `views.js`
must be loaded first, so that views.js has a Global Views-Object)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message