couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: New document sidebar
Date Thu, 19 Jun 2014 21:23:48 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/248#discussion_r13994741
  
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -42,7 +43,6 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb,
         });
       }
     
    -  var Views = {};
    --- End diff --
    
    We are adding more Views with Views.Viewname in this file, but the View Object comes from
`addons/documents/sidebarviews.js`. I am afraid this could lead to issues, where the time
which module is loaded before is very important. I see we depend in sidebarviews on things
like `DeleteDBModal `from this file, what is your opinion on loading this AMD module (documents/views.js)
in `src/fauxton/app/addons/documents/views.js` as a dependency?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message