couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: New document sidebar
Date Thu, 19 Jun 2014 21:09:02 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/248#discussion_r13993956
  
    --- Diff: src/fauxton/app/addons/documents/templates/design_doc_menu.html ---
    @@ -0,0 +1,32 @@
    +<!--
    +Licensed under the Apache License, Version 2.0 (the "License"); you may not
    +use this file except in compliance with the License. You may obtain a copy of
    +the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
    +WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
    +License for the specific language governing permissions and limitations under
    +the License.
    +-->
    +<li class="nav-header">
    +	
    +	<div  class="js-collapse-toggle accordion-header" data-toggle="collapse" data-target="#<%=
ddoc_clean %>" id="nav-header-<%= ddoc_clean %>" >
    +		<div class="accordion-list-item">
    +			<div class="fonticon-play"></div>
    +			<p><%= designDoc%></p>
    --- End diff --
    
    i would use `<-` to avoid XSS issues, e.g. `<%- designDoc%>`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message