Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Date: Thu, 22 May 2014 21:10:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Message-ID: <JIRA.12713373.1399663260043.4218.1400793002021@arcas>
In-Reply-To: <JIRA.12713373.1399663260043@arcas>
References: <JIRA.12713373.1399663260043@arcas>
Subject: [jira] [Commented] (COUCHDB-2238) Do not reference netdna CDN for
 Font Awesome icons in production
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006476#comment-14006476 ] 

ASF GitHub Bot commented on COUCHDB-2238:
-----------------------------------------

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/235

    Fauxton: use local version of font awesome

    We are currently referencing to Font-Awesome on a CDN in the
    variables.less, which is basically nice, but some users of
    CouchDB are firewalled at work and can just use the local
    network.
    
    Additionally offline people without internet can't use Fauxton
    if the font is loaded via CDN.
    
    This also removes the cache-buster for imgs (GET-Params with
    version) in our routing for the local files of the dev-server
    to make it work, in the future we might want to use a real
    router module for the long if/else block.
    
    Closes: COUCHDB-2238
    
    @garrensmith @deathbearbrown is there a special reason why we would keep the CDN?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb net-dna-font-awesome

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #235
    
----
commit 230631a5791c8d5f4014406fec3c3abd8c3ec15b
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-22T21:01:23Z

    Fauxton: use local version of font awesome
    
    We are currently referencing to Font-Awesome on a CDN in the
    variables.less, which is basically nice, but some users of
    CouchDB are firewalled at work and can just use the local
    network.
    
    Additionally offline people without internet can't use Fauxton
    if the font is loaded via CDN.
    
    This also removes the cache-buster for imgs (GET-Params with
    version) in our routing for the local files of the dev-server
    to make it work, in the future we might want to use a real
    router module for the long if/else block.
    
    Closes: COUCHDB-2238

----


> Do not reference netdna CDN for Font Awesome icons in production
> ----------------------------------------------------------------
>
>                 Key: COUCHDB-2238
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2238
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Robert Kowalski
>            Assignee: Robert Kowalski
>
> I just noticed while I was sitting in the train without internet, hacking on Fauxton, that I did not have many icons:
> We are currently referencing to Font-Awesome on a CDN in variables.less, which is basically nice, but some users of CouchDB are firewalled at work and can just use the local network.
> Additionally offline people without internet can't use Fauxton then.


--
This message was sent by Atlassian JIRA
(v6.2#6252)