Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E650118BE for ; Fri, 16 May 2014 21:39:48 +0000 (UTC) Received: (qmail 66464 invoked by uid 500); 16 May 2014 19:03:34 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 61950 invoked by uid 500); 16 May 2014 19:03:30 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 64501 invoked by uid 99); 16 May 2014 18:49:33 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 May 2014 18:49:33 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 3890B92B06F; Fri, 16 May 2014 18:49:33 +0000 (UTC) From: robertkowalski To: dev@couchdb.apache.org Reply-To: dev@couchdb.apache.org References: In-Reply-To: Subject: [GitHub] couchdb pull request: Fauxton: Implement a filter for changes Content-Type: text/plain Message-Id: <20140516184933.3890B92B06F@tyr.zones.apache.org> Date: Fri, 16 May 2014 18:49:33 +0000 (UTC) Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb/pull/227#issuecomment-43366376 I think I fixed everything, thanks for the review :) Just a sidenote: One downside I noticed using the routeObjectEvents is that they make testing a little bit harder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---