couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: Fauxton: use local version of font awesome
Date Thu, 22 May 2014 21:08:41 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/235

    Fauxton: use local version of font awesome

    We are currently referencing to Font-Awesome on a CDN in the
    variables.less, which is basically nice, but some users of
    CouchDB are firewalled at work and can just use the local
    network.
    
    Additionally offline people without internet can't use Fauxton
    if the font is loaded via CDN.
    
    This also removes the cache-buster for imgs (GET-Params with
    version) in our routing for the local files of the dev-server
    to make it work, in the future we might want to use a real
    router module for the long if/else block.
    
    Closes: COUCHDB-2238
    
    @garrensmith @deathbearbrown is there a special reason why we would keep the CDN?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb net-dna-font-awesome

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #235
    
----
commit 230631a5791c8d5f4014406fec3c3abd8c3ec15b
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-22T21:01:23Z

    Fauxton: use local version of font awesome
    
    We are currently referencing to Font-Awesome on a CDN in the
    variables.less, which is basically nice, but some users of
    CouchDB are firewalled at work and can just use the local
    network.
    
    Additionally offline people without internet can't use Fauxton
    if the font is loaded via CDN.
    
    This also removes the cache-buster for imgs (GET-Params with
    version) in our routing for the local files of the dev-server
    to make it work, in the future we might want to use a real
    router module for the long if/else block.
    
    Closes: COUCHDB-2238

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message